Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metrics server listen on localhost by default #5777

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix: metrics server listen on localhost by default #5777

merged 1 commit into from
Jul 20, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jul 19, 2023

Motivation

We are currently not setting the beacon node metrics server host to localhost / 127.0.0.1 by default. This causes it to listen on IPv6 network interface and makes it externally reachable by default (unless firewall is enabled), see #5768 (comment) for further details.

Metric servers should only be explicitly exposed to an external network inferface by setting --metrics.address "0.0.0.0".

Description

Set 127.0.0.1 as default beacon node metrics address.

This is already the case for validator metrics server

lodestar/packages/cli/src/cmds/validator/options.ts

Line 17 in 0884fdf

address: "127.0.0.1",

@nflaig nflaig requested a review from a team as a code owner July 19, 2023 17:53
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 591532e Previous: 29314c9 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 730.93 us/op 474.35 us/op 1.54
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 73.269 us/op 78.355 us/op 0.94
BLS verify - blst-native 1.1808 ms/op 1.2465 ms/op 0.95
BLS verifyMultipleSignatures 3 - blst-native 2.3993 ms/op 2.5472 ms/op 0.94
BLS verifyMultipleSignatures 8 - blst-native 5.1653 ms/op 5.3955 ms/op 0.96
BLS verifyMultipleSignatures 32 - blst-native 18.597 ms/op 19.469 ms/op 0.96
BLS aggregatePubkeys 32 - blst-native 24.632 us/op 25.685 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 97.012 us/op 101.67 us/op 0.95
getAttestationsForBlock 48.321 ms/op 60.960 ms/op 0.79
isKnown best case - 1 super set check 262.00 ns/op 324.00 ns/op 0.81
isKnown normal case - 2 super set checks 254.00 ns/op 338.00 ns/op 0.75
isKnown worse case - 16 super set checks 256.00 ns/op 318.00 ns/op 0.81
CheckpointStateCache - add get delete 4.6820 us/op 5.4590 us/op 0.86
validate api signedAggregateAndProof - struct 2.6847 ms/op 2.9074 ms/op 0.92
validate gossip signedAggregateAndProof - struct 2.6836 ms/op 2.8803 ms/op 0.93
validate api attestation - struct 1.2816 ms/op 1.3710 ms/op 0.93
validate gossip attestation - struct 1.3398 ms/op 1.3980 ms/op 0.96
pickEth1Vote - no votes 1.1711 ms/op 1.3082 ms/op 0.90
pickEth1Vote - max votes 8.9775 ms/op 12.234 ms/op 0.73
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.4343 ms/op 8.7343 ms/op 0.97
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 13.674 ms/op 13.547 ms/op 1.01
pickEth1Vote - Eth1Data fastSerialize value x2048 545.16 us/op 574.27 us/op 0.95
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.8513 ms/op 5.1906 ms/op 1.13
bytes32 toHexString 449.00 ns/op 646.00 ns/op 0.70
bytes32 Buffer.toString(hex) 276.00 ns/op 344.00 ns/op 0.80
bytes32 Buffer.toString(hex) from Uint8Array 412.00 ns/op 569.00 ns/op 0.72
bytes32 Buffer.toString(hex) + 0x 275.00 ns/op 364.00 ns/op 0.76
Object access 1 prop 0.15500 ns/op 0.20100 ns/op 0.77
Map access 1 prop 0.13900 ns/op 0.15900 ns/op 0.87
Object get x1000 7.3880 ns/op 7.7000 ns/op 0.96
Map get x1000 0.58000 ns/op 0.74200 ns/op 0.78
Object set x1000 46.591 ns/op 65.522 ns/op 0.71
Map set x1000 36.891 ns/op 45.648 ns/op 0.81
Return object 10000 times 0.22540 ns/op 0.27230 ns/op 0.83
Throw Error 10000 times 3.6184 us/op 3.9322 us/op 0.92
fastMsgIdFn sha256 / 200 bytes 3.1200 us/op 3.4260 us/op 0.91
fastMsgIdFn h32 xxhash / 200 bytes 253.00 ns/op 336.00 ns/op 0.75
fastMsgIdFn h64 xxhash / 200 bytes 317.00 ns/op 390.00 ns/op 0.81
fastMsgIdFn sha256 / 1000 bytes 10.880 us/op 11.901 us/op 0.91
fastMsgIdFn h32 xxhash / 1000 bytes 372.00 ns/op 483.00 ns/op 0.77
fastMsgIdFn h64 xxhash / 1000 bytes 384.00 ns/op 470.00 ns/op 0.82
fastMsgIdFn sha256 / 10000 bytes 99.159 us/op 105.31 us/op 0.94
fastMsgIdFn h32 xxhash / 10000 bytes 1.8010 us/op 2.0500 us/op 0.88
fastMsgIdFn h64 xxhash / 10000 bytes 1.2560 us/op 1.4140 us/op 0.89
enrSubnets - fastDeserialize 64 bits 1.1460 us/op 1.4760 us/op 0.78
enrSubnets - ssz BitVector 64 bits 385.00 ns/op 511.00 ns/op 0.75
enrSubnets - fastDeserialize 4 bits 157.00 ns/op 237.00 ns/op 0.66
enrSubnets - ssz BitVector 4 bits 394.00 ns/op 522.00 ns/op 0.75
prioritizePeers score -10:0 att 32-0.1 sync 2-0 95.813 us/op 114.42 us/op 0.84
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 117.69 us/op 162.99 us/op 0.72
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 158.26 us/op 200.78 us/op 0.79
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 282.48 us/op 340.02 us/op 0.83
prioritizePeers score 0:0 att 64-1 sync 4-1 327.25 us/op 390.37 us/op 0.84
array of 16000 items push then shift 1.5252 us/op 1.6473 us/op 0.93
LinkedList of 16000 items push then shift 8.5450 ns/op 9.6610 ns/op 0.88
array of 16000 items push then pop 45.496 ns/op 53.942 ns/op 0.84
LinkedList of 16000 items push then pop 8.5280 ns/op 9.2420 ns/op 0.92
array of 24000 items push then shift 2.3503 us/op 2.5286 us/op 0.93
LinkedList of 24000 items push then shift 8.7060 ns/op 10.465 ns/op 0.83
array of 24000 items push then pop 103.22 ns/op 128.21 ns/op 0.81
LinkedList of 24000 items push then pop 8.4710 ns/op 9.8540 ns/op 0.86
intersect bitArray bitLen 8 6.6300 ns/op 8.4560 ns/op 0.78
intersect array and set length 8 56.526 ns/op 91.842 ns/op 0.62
intersect bitArray bitLen 128 31.129 ns/op 39.313 ns/op 0.79
intersect array and set length 128 744.67 ns/op 1.2084 us/op 0.62
bitArray.getTrueBitIndexes() bitLen 128 1.4740 us/op 2.2930 us/op 0.64
bitArray.getTrueBitIndexes() bitLen 248 2.5260 us/op 3.9940 us/op 0.63
bitArray.getTrueBitIndexes() bitLen 512 4.8100 us/op 7.6110 us/op 0.63
Buffer.concat 32 items 933.00 ns/op 1.2760 us/op 0.73
Uint8Array.set 32 items 1.8900 us/op 1.9000 us/op 0.99
transfer serialized Status (84 B) 1.8930 us/op 2.1480 us/op 0.88
copy serialized Status (84 B) 1.4370 us/op 1.7760 us/op 0.81
transfer serialized SignedVoluntaryExit (112 B) 1.9070 us/op 2.0950 us/op 0.91
copy serialized SignedVoluntaryExit (112 B) 1.4890 us/op 1.6890 us/op 0.88
transfer serialized ProposerSlashing (416 B) 2.9120 us/op 2.4460 us/op 1.19
copy serialized ProposerSlashing (416 B) 2.3930 us/op 2.0730 us/op 1.15
transfer serialized Attestation (485 B) 2.8830 us/op 2.3200 us/op 1.24
copy serialized Attestation (485 B) 2.6500 us/op 2.5800 us/op 1.03
transfer serialized AttesterSlashing (33232 B) 2.5080 us/op 2.6460 us/op 0.95
copy serialized AttesterSlashing (33232 B) 5.1470 us/op 6.5030 us/op 0.79
transfer serialized Small SignedBeaconBlock (128000 B) 2.4560 us/op 3.1970 us/op 0.77
copy serialized Small SignedBeaconBlock (128000 B) 13.138 us/op 15.896 us/op 0.83
transfer serialized Avg SignedBeaconBlock (200000 B) 2.8380 us/op 3.4880 us/op 0.81
copy serialized Avg SignedBeaconBlock (200000 B) 19.814 us/op 21.786 us/op 0.91
transfer serialized BlobsSidecar (524380 B) 2.5880 us/op 3.7240 us/op 0.69
copy serialized BlobsSidecar (524380 B) 86.013 us/op 92.760 us/op 0.93
transfer serialized Big SignedBeaconBlock (1000000 B) 2.6620 us/op 3.6620 us/op 0.73
copy serialized Big SignedBeaconBlock (1000000 B) 161.46 us/op 162.00 us/op 1.00
pass gossip attestations to forkchoice per slot 2.1178 ms/op 2.1972 ms/op 0.96
forkChoice updateHead vc 100000 bc 64 eq 0 2.0615 ms/op 2.2794 ms/op 0.90
forkChoice updateHead vc 600000 bc 64 eq 0 13.385 ms/op 14.837 ms/op 0.90
forkChoice updateHead vc 1000000 bc 64 eq 0 22.244 ms/op 20.128 ms/op 1.11
forkChoice updateHead vc 600000 bc 320 eq 0 16.300 ms/op 17.755 ms/op 0.92
forkChoice updateHead vc 600000 bc 1200 eq 0 80.125 ms/op 93.063 ms/op 0.86
forkChoice updateHead vc 600000 bc 64 eq 1000 21.297 ms/op 22.737 ms/op 0.94
forkChoice updateHead vc 600000 bc 64 eq 10000 22.698 ms/op 24.729 ms/op 0.92
forkChoice updateHead vc 600000 bc 64 eq 300000 28.365 ms/op 31.478 ms/op 0.90
computeDeltas 2.8732 ms/op 3.1202 ms/op 0.92
computeProposerBoostScoreFromBalances 371.89 us/op 404.69 us/op 0.92
altair processAttestation - 250000 vs - 7PWei normalcase 2.1529 ms/op 2.6231 ms/op 0.82
altair processAttestation - 250000 vs - 7PWei worstcase 3.1413 ms/op 4.1324 ms/op 0.76
altair processAttestation - setStatus - 1/6 committees join 218.79 us/op 162.93 us/op 1.34
altair processAttestation - setStatus - 1/3 committees join 403.81 us/op 313.32 us/op 1.29
altair processAttestation - setStatus - 1/2 committees join 540.03 us/op 449.73 us/op 1.20
altair processAttestation - setStatus - 2/3 committees join 733.39 us/op 526.18 us/op 1.39
altair processAttestation - setStatus - 4/5 committees join 997.20 us/op 744.71 us/op 1.34
altair processAttestation - setStatus - 100% committees join 1.1203 ms/op 879.64 us/op 1.27
altair processBlock - 250000 vs - 7PWei normalcase 10.075 ms/op 10.843 ms/op 0.93
altair processBlock - 250000 vs - 7PWei normalcase hashState 17.226 ms/op 18.362 ms/op 0.94
altair processBlock - 250000 vs - 7PWei worstcase 37.498 ms/op 42.559 ms/op 0.88
altair processBlock - 250000 vs - 7PWei worstcase hashState 58.447 ms/op 62.653 ms/op 0.93
phase0 processBlock - 250000 vs - 7PWei normalcase 1.8965 ms/op 2.4934 ms/op 0.76
phase0 processBlock - 250000 vs - 7PWei worstcase 27.555 ms/op 32.322 ms/op 0.85
altair processEth1Data - 250000 vs - 7PWei normalcase 455.43 us/op 606.51 us/op 0.75
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 9.3560 us/op 16.189 us/op 0.58
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 58.074 us/op 53.286 us/op 1.09
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 15.848 us/op 21.689 us/op 0.73
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 7.6630 us/op 11.868 us/op 0.65
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 158.28 us/op 193.39 us/op 0.82
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.0158 ms/op 1.5350 ms/op 0.66
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.4392 ms/op 2.0827 ms/op 0.69
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.6939 ms/op 1.8979 ms/op 0.89
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.7482 ms/op 4.6495 ms/op 0.59
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.1982 ms/op 2.8007 ms/op 0.78
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.1665 ms/op 6.6638 ms/op 0.78
Tree 40 250000 create 320.94 ms/op 580.14 ms/op 0.55
Tree 40 250000 get(125000) 191.56 ns/op 227.41 ns/op 0.84
Tree 40 250000 set(125000) 842.54 ns/op 1.3603 us/op 0.62
Tree 40 250000 toArray() 16.241 ms/op 28.167 ms/op 0.58
Tree 40 250000 iterate all - toArray() + loop 16.199 ms/op 27.594 ms/op 0.59
Tree 40 250000 iterate all - get(i) 61.761 ms/op 85.649 ms/op 0.72
MutableVector 250000 create 8.8914 ms/op 17.551 ms/op 0.51
MutableVector 250000 get(125000) 6.3670 ns/op 7.2150 ns/op 0.88
MutableVector 250000 set(125000) 249.01 ns/op 566.75 ns/op 0.44
MutableVector 250000 toArray() 2.7183 ms/op 5.8786 ms/op 0.46
MutableVector 250000 iterate all - toArray() + loop 2.8022 ms/op 5.3880 ms/op 0.52
MutableVector 250000 iterate all - get(i) 1.5074 ms/op 1.7317 ms/op 0.87
Array 250000 create 2.5483 ms/op 5.0100 ms/op 0.51
Array 250000 clone - spread 1.1743 ms/op 1.5843 ms/op 0.74
Array 250000 get(125000) 0.57200 ns/op 0.80800 ns/op 0.71
Array 250000 set(125000) 0.64400 ns/op 0.91000 ns/op 0.71
Array 250000 iterate all - loop 81.554 us/op 89.733 us/op 0.91
effectiveBalanceIncrements clone Uint8Array 300000 27.974 us/op 43.106 us/op 0.65
effectiveBalanceIncrements clone MutableVector 300000 350.00 ns/op 338.00 ns/op 1.04
effectiveBalanceIncrements rw all Uint8Array 300000 174.89 us/op 185.95 us/op 0.94
effectiveBalanceIncrements rw all MutableVector 300000 80.401 ms/op 98.113 ms/op 0.82
phase0 afterProcessEpoch - 250000 vs - 7PWei 110.91 ms/op 130.64 ms/op 0.85
phase0 beforeProcessEpoch - 250000 vs - 7PWei 30.967 ms/op 44.919 ms/op 0.69
altair processEpoch - mainnet_e81889 308.77 ms/op 376.53 ms/op 0.82
mainnet_e81889 - altair beforeProcessEpoch 46.311 ms/op 74.715 ms/op 0.62
mainnet_e81889 - altair processJustificationAndFinalization 14.085 us/op 28.804 us/op 0.49
mainnet_e81889 - altair processInactivityUpdates 5.1359 ms/op 9.0422 ms/op 0.57
mainnet_e81889 - altair processRewardsAndPenalties 67.214 ms/op 69.712 ms/op 0.96
mainnet_e81889 - altair processRegistryUpdates 2.5550 us/op 6.0210 us/op 0.42
mainnet_e81889 - altair processSlashings 464.00 ns/op 1.3600 us/op 0.34
mainnet_e81889 - altair processEth1DataReset 612.00 ns/op 1.2050 us/op 0.51
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.1621 ms/op 2.2977 ms/op 0.51
mainnet_e81889 - altair processSlashingsReset 2.9260 us/op 7.9540 us/op 0.37
mainnet_e81889 - altair processRandaoMixesReset 6.0980 us/op 9.0800 us/op 0.67
mainnet_e81889 - altair processHistoricalRootsUpdate 847.00 ns/op 1.5690 us/op 0.54
mainnet_e81889 - altair processParticipationFlagUpdates 2.4670 us/op 3.6570 us/op 0.67
mainnet_e81889 - altair processSyncCommitteeUpdates 575.00 ns/op 977.00 ns/op 0.59
mainnet_e81889 - altair afterProcessEpoch 122.12 ms/op 154.51 ms/op 0.79
phase0 processEpoch - mainnet_e58758 354.71 ms/op 437.01 ms/op 0.81
mainnet_e58758 - phase0 beforeProcessEpoch 145.04 ms/op 185.69 ms/op 0.78
mainnet_e58758 - phase0 processJustificationAndFinalization 15.195 us/op 26.183 us/op 0.58
mainnet_e58758 - phase0 processRewardsAndPenalties 66.784 ms/op 81.868 ms/op 0.82
mainnet_e58758 - phase0 processRegistryUpdates 11.134 us/op 20.351 us/op 0.55
mainnet_e58758 - phase0 processSlashings 587.00 ns/op 1.1120 us/op 0.53
mainnet_e58758 - phase0 processEth1DataReset 606.00 ns/op 921.00 ns/op 0.66
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.5227 ms/op 3.5213 ms/op 0.43
mainnet_e58758 - phase0 processSlashingsReset 2.1090 us/op 6.8270 us/op 0.31
mainnet_e58758 - phase0 processRandaoMixesReset 4.6530 us/op 9.5550 us/op 0.49
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.4880 us/op 1.5470 us/op 0.96
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.4400 us/op 9.5720 us/op 0.57
mainnet_e58758 - phase0 afterProcessEpoch 101.46 ms/op 122.29 ms/op 0.83
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2881 ms/op 2.1632 ms/op 0.60
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5227 ms/op 2.5435 ms/op 0.60
altair processInactivityUpdates - 250000 normalcase 28.535 ms/op 35.482 ms/op 0.80
altair processInactivityUpdates - 250000 worstcase 29.165 ms/op 34.574 ms/op 0.84
phase0 processRegistryUpdates - 250000 normalcase 14.263 us/op 15.964 us/op 0.89
phase0 processRegistryUpdates - 250000 badcase_full_deposits 412.41 us/op 459.86 us/op 0.90
phase0 processRegistryUpdates - 250000 worstcase 0.5 152.24 ms/op 148.07 ms/op 1.03
altair processRewardsAndPenalties - 250000 normalcase 71.428 ms/op 74.468 ms/op 0.96
altair processRewardsAndPenalties - 250000 worstcase 69.385 ms/op 76.992 ms/op 0.90
phase0 getAttestationDeltas - 250000 normalcase 9.3583 ms/op 9.0246 ms/op 1.04
phase0 getAttestationDeltas - 250000 worstcase 10.085 ms/op 10.640 ms/op 0.95
phase0 processSlashings - 250000 worstcase 2.5422 ms/op 2.9174 ms/op 0.87
altair processSyncCommitteeUpdates - 250000 176.72 ms/op 176.82 ms/op 1.00
BeaconState.hashTreeRoot - No change 340.00 ns/op 281.00 ns/op 1.21
BeaconState.hashTreeRoot - 1 full validator 51.897 us/op 54.282 us/op 0.96
BeaconState.hashTreeRoot - 32 full validator 500.61 us/op 568.36 us/op 0.88
BeaconState.hashTreeRoot - 512 full validator 5.1832 ms/op 5.9092 ms/op 0.88
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 61.573 us/op 66.046 us/op 0.93
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 867.91 us/op 937.44 us/op 0.93
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.513 ms/op 12.512 ms/op 0.92
BeaconState.hashTreeRoot - 1 balances 49.009 us/op 54.402 us/op 0.90
BeaconState.hashTreeRoot - 32 balances 447.37 us/op 532.65 us/op 0.84
BeaconState.hashTreeRoot - 512 balances 4.1367 ms/op 5.3609 ms/op 0.77
BeaconState.hashTreeRoot - 250000 balances 73.024 ms/op 83.221 ms/op 0.88
aggregationBits - 2048 els - zipIndexesInBitList 17.633 us/op 25.647 us/op 0.69
regular array get 100000 times 44.987 us/op 41.109 us/op 1.09
wrappedArray get 100000 times 33.392 us/op 36.073 us/op 0.93
arrayWithProxy get 100000 times 14.671 ms/op 15.949 ms/op 0.92
ssz.Root.equals 243.00 ns/op 258.00 ns/op 0.94
byteArrayEquals 236.00 ns/op 261.00 ns/op 0.90
shuffle list - 16384 els 7.1887 ms/op 7.6511 ms/op 0.94
shuffle list - 250000 els 104.43 ms/op 111.90 ms/op 0.93
processSlot - 1 slots 8.3600 us/op 9.6550 us/op 0.87
processSlot - 32 slots 1.4249 ms/op 1.4613 ms/op 0.98
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 56.119 ms/op 66.220 ms/op 0.85
getCommitteeAssignments - req 1 vs - 250000 vc 2.5774 ms/op 3.2557 ms/op 0.79
getCommitteeAssignments - req 100 vs - 250000 vc 3.8530 ms/op 4.5431 ms/op 0.85
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1814 ms/op 4.6061 ms/op 0.91
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.1400 ns/op 6.1200 ns/op 0.84
state getBlockRootAtSlot - 250000 vs - 7PWei 618.92 ns/op 1.1935 us/op 0.52
computeProposers - vc 250000 9.5782 ms/op 10.158 ms/op 0.94
computeEpochShuffling - vc 250000 111.14 ms/op 126.31 ms/op 0.88
getNextSyncCommittee - vc 250000 161.01 ms/op 174.83 ms/op 0.92
computeSigningRoot for AttestationData 14.053 us/op 15.337 us/op 0.92
hash AttestationData serialized data then Buffer.toString(base64) 2.3834 us/op 2.4072 us/op 0.99
toHexString serialized data 1.2209 us/op 1.0598 us/op 1.15
Buffer.toString(base64) 252.32 ns/op 231.00 ns/op 1.09

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 81f7ab5 into unstable Jul 20, 2023
11 checks passed
@wemeetagain wemeetagain deleted the nflaig/fix-metrics-address branch July 20, 2023 12:59
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@twoeths twoeths twoeths approved these changes

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nflaig @wemeetagain @twoeths @dapplion